Skip to content

ci: fix Codecov slug after repo rename (modules -> framework) - #149

Merged
tmgbedu merged 1 commit into
mainfrom
task/codecov-slug-fix
Jul 9, 2026
Merged

ci: fix Codecov slug after repo rename (modules -> framework)#149
tmgbedu merged 1 commit into
mainfrom
task/codecov-slug-fix

Conversation

@tmgbedu

@tmgbedu tmgbedu commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Problem

The repo was renamed fastapi-startkit-modules -> fastapi-startkit-framework, but the CI upload slug and the README badge/link URLs still referenced the old name. Uploads and the badge therefore hit the wrong (empty) Codecov project, so the badge shows no data.

Changes

  • .github/workflows/test.ymlcodecov-action slug -> fastapi-startkit/fastapi-startkit-framework.
  • readme.md — badge SVG URL + link target -> framework.
  • fastapi_startkit/README.md — badge (line 3) + prose Codecov link -> framework.
  • packages/fastapi-vite-plugin/package.jsonrepository/bugs URLs -> framework (also carried the old slug; fixed so VERIFY passes).
  • codecov.yml (new, repo root) — minimal permissive config: project + patch status set to informational: true so coverage never fails PRs; defines the fastapi_startkit flag (paths fastapi_startkit/src/fastapi_startkit/, carryforward).

Verification

  • grep -rn fastapi-startkit-modules . -> 0 matches.
  • codecov.yml validated against https://codecov.io/validate -> Valid!

⚠️ Manual steps required (cannot be done from the repo)

  1. Activate the Codecov project for fastapi-startkit/fastapi-startkit-framework in the Codecov dashboard.
  2. Set the CODECOV_TOKEN secret for the renamed project in the repo's GitHub Actions secrets.

Note: the local git origin remote still points at the old ...-modules.git URL; GitHub auto-redirects so pushes work, but the remote could be updated separately.

The repo was renamed fastapi-startkit-modules -> fastapi-startkit-framework,
but the CI upload slug and README badge/link URLs still pointed at the old
name, so uploads and the badge hit the wrong (empty) Codecov project.

- test.yml: update codecov-action slug to the new repo
- readme.md, fastapi_startkit/README.md: fix badge SVG + link targets and prose link
- packages/fastapi-vite-plugin/package.json: update repository/bugs URLs
- add permissive codecov.yml (informational project+patch status that never
  fails PRs; define the fastapi_startkit flag)
@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

@tmgbedu

tmgbedu commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

✅ Code Review: APPROVE

Reviewed full diff + ran all checks on task/codecov-slug-fix. (Formal --approve blocked by GitHub since the reviewer account authored the PR; recording verdict as a comment.)

Verification

  1. grep -rn fastapi-startkit-modules .0 matches on PR branch ✔
  2. test.yml: slug fastapi-startkit/fastapi-startkit-framework, flags: fastapi_startkit, files: fastapi_startkit/coverage.xml
  3. readme.md + fastapi_startkit/README.md: badge URLs and link targets updated ✔
  4. codecov.yml (new): Codecov validator → Valid!; project+patch informational: true, require_changes: false → never fails PRs; fastapi_startkit flag defined ✔
  5. fastapi-vite-plugin/package.json: repo/bugs URLs → framework ✔
  6. Only 5 expected files changed, no unintended files ✔

Minor (non-blocking): flag paths: fastapi_startkit/src/fastapi_startkit/ must match the paths in coverage.xml; being informational, a mismatch only weakens per-flag filtering, never fails CI. Sanity-check on first upload.

Config-only (no code/SQL/ORM) → no tests required. Reminder: the 2 manual steps (activate Codecov project + set CODECOV_TOKEN) are needed for the badge to populate.

@tmgbedu
tmgbedu merged commit 29f83a2 into main Jul 9, 2026
4 checks passed
@tmgbedu
tmgbedu deleted the task/codecov-slug-fix branch July 9, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant