Skip to content

Conversation

@gomnitrix
Copy link
Contributor

Draft PR for early feedback on an xtask-based bootstrap implementation.

@gomnitrix
Copy link
Contributor Author

Hi @tisonkun, thanks again for the previous reviews.

I went back to my earlier implementation and tried to address the points you raised back then, simplify some parts of the code, and also incorporate some ideas from the recent Python script you added.
I also tried adding a bootstrap --cleanup option to provide a clean way to remove the bootstrap code.

I’m not entirely sure if this approach makes sense yet, so for now I’m mainly looking for a quick sanity check. If you have a chance to take a look, I’d really appreciate any feedback. If it looks roughly okay, I can polish it up and make this ready for a proper review.

Thanks!

@tisonkun tisonkun self-requested a review January 4, 2026 01:02
@tisonkun tisonkun changed the title [WIP] refactor: migrate project bootstrap to xtasks refactor: migrate project bootstrap to xtasks Jan 4, 2026
@tisonkun tisonkun changed the title refactor: migrate project bootstrap to xtasks refactor: migrate project bootstrap to xtask Jan 4, 2026
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun force-pushed the dev-subcmd-bootstrap branch from fe505f6 to 5214516 Compare January 4, 2026 11:59
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun force-pushed the dev-subcmd-bootstrap branch from 5214516 to 3a13d39 Compare January 4, 2026 12:04
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun force-pushed the dev-subcmd-bootstrap branch from 4f82f04 to fe8cd8b Compare January 4, 2026 12:08
@tisonkun tisonkun marked this pull request as ready for review January 4, 2026 12:11
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Updated and merging ...

@tisonkun tisonkun merged commit 9beba44 into fast:main Jan 4, 2026
10 checks passed
@gomnitrix gomnitrix deleted the dev-subcmd-bootstrap branch January 4, 2026 14:59
@gomnitrix
Copy link
Contributor Author

Thanks for your contribution! Updated and merging ...

Thanks for your help! I saw your updates, and the renaming and overriding feel like a much better approach than using features. Learned a lot, thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants