Repository navigation
One player login for all servers of the same owner - #9
Merged
Merged
Conversation
A PIN login also sets a signed, domain-wide cookie with the uuid and the server's owner. Other servers of that owner where the player has played log them in as their own player; servers of other owners ignore it, because a modified plugin can log its owner in as anyone. Logging out on one server ends the login on all of them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A PIN login now also counts on the other servers of the same owner where the player has played (signed domain-wide cookie with uuid and owner). Servers of other owners ignore it, since a modified plugin can log its owner in as anyone (ADR 0004). Logging out on one of them ends the login on all.
Tests
764 passed locally (7 new SSO tests, isolation test now against a server of another owner).