Move to maturin as a Build System#955
Open
riesentoaster wants to merge 12 commits into
Open
Conversation
|
| Branch | chore/manturin |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| tests/test_benchmarks.py::test_generate_with_single_hard_constraint | 📈 view plot 🚷 view threshold | 1,464.75 ms(-23.76%)Baseline: 1,921.33 ms | 2,124.20 ms (68.96%) |
| tests/test_benchmarks.py::test_generate_with_single_soft_constraint | 📈 view plot 🚷 view threshold | 68,989.80 ms(+22.97%)Baseline: 56,103.05 ms | 87,573.95 ms (78.78%) |
| tests/test_benchmarks.py::test_init_fandango | 📈 view plot 🚷 view threshold | 136.58 ms(-10.28%)Baseline: 152.23 ms | 166.84 ms (81.86%) |
| tests/test_benchmarks.py::test_parse_spec | 📈 view plot 🚷 view threshold | 136.94 ms(-10.51%)Baseline: 153.03 ms | 166.60 ms (82.20%) |
Collaborator
Author
|
(CodeQL is still broken for now because it can no longer auto-detect the build system. We would need to either just drop it or provide a custom config, but that's definitely doable.) |
1142fe2 to
4bbdb9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason:
scikit-build-corewas just creating too many problems. We still want a parallel build. As a nice side effect, this also prepares the ability to write hot-path performance-critical parts in Rust.Changes:
ccmoduleFANDANGO_SKIP_CPP_PARSER(andFANDANGO_REQUIRE_BINARY_BUILD) — we always build on developer machines and will have to do this as soon as we move anything serious to Rust; consumers download binaries anyway, they don't need the toolchain