fix(core): answer the first message in a room you just joined - #53
Merged
Conversation
The bot greets a new room with "I capture what your family drops here", and then ignored the very next thing dropped. Whoever invited it had to say the same thing twice, with nothing to explain why the first attempt did nothing. Each room has a cursor marking how far the bot has read, so a restart does not replay old chatter. For a room it had just joined that cursor was set by whichever poll first noticed the room, which also discarded everything sent in the meantime. The welcome arrives from the join itself, so a reply to it landed exactly in that gap. The cursor now starts at the join. Enables the room-modes spec, which has been parked as unverified since June and was failing for this reason. It was also waiting on the bot before sending, but a join is a membership change rather than a message, so it began talking before anyone was listening.
Nimbalyst writes plan documents under nimbalyst-local/. They are working notes for one machine, not product source, and this repo is public.
arthware-dev
force-pushed
the
fix/enable-room-modes-e2e
branch
from
August 2, 2026 09:21
43f7d5e to
0541dfc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bot greets a new room, then ignored the very next message. Whoever invited it had to say the same thing twice.
Each room has a cursor so a restart does not replay old chatter. For a freshly joined room it was set by whichever poll first noticed the room, which also discarded everything sent in between. The welcome comes from the join itself, so a reply to it landed exactly in that gap.
_anchor_cursor_on_joinnow sets it at the join; a re-invite does not move an existing cursor.Also un-parks
test_room_modes_e2e.py, which caught this and has beenxfail(strict=False)since June. Its readiness wait treated the bot'sm.room.memberjoin as "listening", so it also sent too early. No parked intent-specs remain.Verified green on the rig. Unit suite 2105 passed.
Refs FAM-6.