Remove trailing whitespace and add .editorconfig#26
Open
familiarcow wants to merge 1 commit into
Open
Conversation
Strips trailing whitespace from all source, template, asset, and config files identified in #23, applied to current main. Pure formatting — no behavioral change. Adds .editorconfig with trim_trailing_whitespace = true so this doesn't regress. Markdown files are exempted since trailing-space-as-line-break is sometimes meaningful there. Co-authored-by: koitsu <jdc@koitsu.org>
Deploying rune-tools with
|
| Latest commit: |
822cc89
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e300ae69.rune-tools.pages.dev |
| Branch Preview URL: | https://remove-trailing-whitespace.rune-tools.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces #23 with the same whitespace cleanup applied to current main, plus a small addition to prevent recurrence:
.editorconfigwithtrim_trailing_whitespace = trueso editors automatically clean up new contributions and we don't have to redo this in 6 months. Markdown is exempted (trailing two-space-as-linebreak is sometimes meaningful there).Why a fresh PR instead of rebasing #23
#23 was based on
5813e8d, several commits behind currentmain. Most files in the original PR have moved (PR #21 thornode rewrite, the Liquify failover work, PR #24 take-over, etc.) so a rebase would conflict on most files. The whitespace fix is a deterministic transform — re-applying programmatically against currentmainproduces a cleaner result with full @koitsu attribution preserved viaCo-authored-by.Test plan
npx vite buildsucceeds, identical chunk sizes to pre-changenpm run dev