gitignore .svelte-kit, add lean root tsconfig.json#25
Open
familiarcow wants to merge 1 commit into
Open
Conversation
The .svelte-kit/ directory is regenerated on every dev/build run, but it was tracked in git — the working tree has been showing autogen drift since we started. Add it to .gitignore and remove it from tracking. Add a minimal root tsconfig.json that extends the SvelteKit-generated one and sets verbatimModuleSyntax: true. This silences the warning printed on every build: The TypeScript option verbatimModuleSyntax is now required when using Svelte files with lang="ts". Please add it to your tsconfig.json. (Affiliates.svelte and TokenWhitelist.svelte use lang="ts", so the warning is real today.) Replaces the autogen-rebuild approach in #22 with the underlying fix, and deliberately omits the strict / checkJs / isolatedModules options from that PR — those would lock in 2300+ existing svelte-check errors as the new IDE baseline, which is a significant policy change that deserves its own decision. Co-authored-by: koitsu <jdc@koitsu.org>
Deploying rune-tools with
|
| Latest commit: |
0c914fc
|
| Status: | 🚫 Build failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces #22 with a focused fix:
That warning is real: `Affiliates.svelte` and `TokenWhitelist.svelte` use `<script lang="ts">`. Verified the warning is gone after this change.
Why not merge #22 as-is
#22 bundled three things; this PR keeps the one that fixes the actual problem and drops the rest:
Credits @koitsu for identifying the warning fix; closing #22 in favor of this.
Test plan