Use fakechris Docker namespace and publish multi-arch images#22
Use fakechris Docker namespace and publish multi-arch images#22
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 2 minutes and 0 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the default Docker image namespace from 'turnkeyai' to 'fakechris' across the README documentation and Docker Compose configuration files. The review feedback correctly identifies that several environment variable overrides in the README examples are now redundant because they match the new default values defined in the compose files, and suggests simplifying these commands for better readability.
| INVOLUTE_IMAGE_NAMESPACE=fakechris INVOLUTE_IMAGE_TAG=latest pnpm compose:pull | ||
| INVOLUTE_IMAGE_NAMESPACE=fakechris INVOLUTE_IMAGE_TAG=latest pnpm compose:pull:up |
There was a problem hiding this comment.
The environment variables INVOLUTE_IMAGE_NAMESPACE=fakechris and INVOLUTE_IMAGE_TAG=latest are now redundant in these examples because they match the default values defined in the updated docker-compose.images.yml and docker-compose.prod.images.yml files. Removing them simplifies the commands for users.
| INVOLUTE_IMAGE_NAMESPACE=fakechris INVOLUTE_IMAGE_TAG=latest pnpm compose:pull | |
| INVOLUTE_IMAGE_NAMESPACE=fakechris INVOLUTE_IMAGE_TAG=latest pnpm compose:pull:up | |
| pnpm compose:pull | |
| pnpm compose:pull:up |
| INVOLUTE_IMAGE_NAMESPACE=fakechris INVOLUTE_IMAGE_TAG=latest \ | ||
| docker compose -f docker-compose.images.yml up -d db server web |
There was a problem hiding this comment.
These environment variables are redundant as they match the new defaults in the compose configuration. The command can be simplified by removing them.
| INVOLUTE_IMAGE_NAMESPACE=fakechris INVOLUTE_IMAGE_TAG=latest \ | |
| docker compose -f docker-compose.images.yml up -d db server web | |
| docker compose -f docker-compose.images.yml up -d db server web |
| INVOLUTE_IMAGE_NAMESPACE=fakechris INVOLUTE_IMAGE_TAG=latest \ | ||
| docker compose --env-file .env.production \ | ||
| -f docker-compose.prod.images.yml up -d |
There was a problem hiding this comment.
These environment variables are redundant as they match the new defaults in the compose configuration. Removing them makes the production example cleaner and easier to follow.
| INVOLUTE_IMAGE_NAMESPACE=fakechris INVOLUTE_IMAGE_TAG=latest \ | |
| docker compose --env-file .env.production \ | |
| -f docker-compose.prod.images.yml up -d | |
| docker compose --env-file .env.production \ | |
| -f docker-compose.prod.images.yml up -d |
Summary\n- Switch Docker image docs and compose defaults to fakechris namespace\n- Publish Docker images for linux/amd64 and linux/arm64 via QEMU/Buildx\n\n## Validation\n- ruby -e "require 'yaml'; YAML.load_file('.github/workflows/docker-publish.yml'); puts 'workflow yaml ok'"\n- docker compose -f docker-compose.images.yml config\n- docker compose --env-file .env.production.example -f docker-compose.prod.images.yml config\n\nNote: docs/handoff-droid.md is local untracked state and is not included.