Route the last three test servers through the port allocator - #17
Merged
Conversation
The first pass at #14 changed startTestServer and left admin-workspaces, service-auth and health binding on their own, so the collision stayed reachable from three files. They now share the allocator. The suite greps itself for the pattern, which is what would have caught the miss the first time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #16, which was incomplete. It changed
startTestServerand stopped there, while three files build their own server and kept binding from the ephemeral range:All three now go through the same allocator, which is exported for that purpose.
The second guard is the more useful half. It greps the suite for the pattern, so the next server that binds this way fails the test rather than waiting to be noticed:
Full suite: 35 files, 351 tests, green. Typecheck clean.
Closes #14