feat: 16.5.3 ci code coverage & quality gates - #81
Merged
Merged
Conversation
vieiralucas
added a commit
that referenced
this pull request
Mar 21, 2026
There was a problem hiding this comment.
1 issue found across 9 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/coverage.yml">
<violation number="1" location=".github/workflows/coverage.yml:97">
P2: This workflow reports coverage but does not implement an actual gate/regression check, so coverage drops will not fail CI.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
- coverage.yml: runs cargo-llvm-cov on every PR and push to main - per-crate coverage breakdown in github step summary - security-critical path coverage (auth, cluster, tls config) highlighted - temporarily includes feature branch trigger for verification
The Test job in ci.yml now runs tests with cargo-llvm-cov instead of plain nextest, producing coverage as a side effect. This eliminates: - a redundant full workspace build (coverage.yml did its own build) - a redundant test run (same tests, just uninstrumented) The standalone coverage.yml is deleted. One build, one test run, coverage included.
- fix coverage report: use contains/endswith instead of startswith for jq file path matching (paths are absolute in llvm-cov JSON output) - format overall percentage to 1 decimal place - add benchmark results to github step summary in bench-regression.yml
vieiralucas
force-pushed
the
feat/16.5.3-ci-code-coverage-quality-gates
branch
from
March 22, 2026 01:05
eb1b4cc to
4ab17bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/coverage.ymlwithcargo-llvm-cov+nextest--no-fail-fastensures coverage reports even if individual tests have issuesTest plan
main+pull_requestafter verification🤖 Generated with Claude Code
Summary by cubic
Integrates code coverage into the main CI test job using
cargo-llvm-cov+nextest, and posts overall, per-crate, and security-path coverage in the PR summary. Also adds a readable benchmark summary to the regression workflow.New Features
.github/workflows/ci.yml“Test + Coverage” job; removes the standalone coverage workflow.llvm-tools-previewandcargo-llvm-cov,cargo-nextest; runs:cargo llvm-cov nextest --workspace --exclude fila-bench --exclude fila-e2e --no-fail-fast --json --summary-only --output-path coverage.json.crates/fila-core/src/broker/auth.rs,crates/fila-server/src/auth.rs,crates/fila-core/src/cluster/, and TLS config incrates/fila-core/src/broker/config.rs.bench-regression.ymlwith “vs main baseline” when available, or a fallback table frombench-aggregated.json.Bug Fixes
contains/endswith.Written for commit 4ab17bd. Summary will update on new commits.
Benchmark Results (vs main baseline)
Baseline commit:
64935c6PR commit:592fcc1Threshold: 10%Summary: 10 regressed, 2 improved, 16 unchanged