Early-inject Phase 0: native routing, UE TAA-off, early_color glue - #61
GorgotsRoman wants to merge 7 commits into
Conversation
Adds settings.json seeding, quality presets, and offline dlss5-feed.cfg / FX uniform editing. Install writes those defaults; post-install verifies critical files. Official Feeder release zip only (no bundled overwrite). Follow-up to closed faisalkindi#55; Feeder-side work lives in jlrouzies-fr/DLSS5-Feeder#76. Co-authored-by: Cursor <cursoragent@cursor.com>
Add Reset to Feeder defaults (work 100%, ofa off, adaptive reset) and rustfmt the PR branch. Co-authored-by: Cursor <cursoragent@cursor.com>
Adds dlss5-perf.jsonl nearest-neighbour expected FPS on the Setup knobs panel (honest estimate; needs in-game samples). Stacked on the Settings / offline cfg PR. Companion writer: jlrouzies-fr/DLSS5-Feeder#76. Co-authored-by: Cursor <cursoragent@cursor.com>
Local game_overrides.json seeds Feeder cfg quirks at Install. Cards and Setup always resolve launcher folders to the canonical Shipping exe via find_game_exes / resolve_target (reconciled with 32-bit and D3D9/import rules on main). Stacked on Settings + perf PRs; no bundled Feeder patches. Follow-up to closed faisalkindi#55. Co-authored-by: Cursor <cursoragent@cursor.com>
Prefer Opti/RenoDX on native DLSS, seed UE TAA-off and tighter ME velocity overrides, and expose early_color cfg/status without bundling Feeder binaries. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Two things here: one I like, one I want changed before it goes near The stack is now four deep. #61 is based on #59, which contains #58 and #57. That means #61's 4,275-line diff is mostly code I have already reviewed twice, and none of it can merge until the base does. I am not going to review a fourth copy of the same lines — let's land #58 first (it is verified and waiting), then rebase down the chain as you planned. The part I want changed: writing to the game's
This tool does not currently modify a game's own configuration files, and I would like to keep that line clean. Everything it writes today is either a file it brought ( If it stays, it needs all four of these:
Otherwise I would rather it were a printed instruction than a silent edit: "turn TAA off in this game's settings for a better result" costs the user ten seconds and costs us nothing in trust. The parts I like: preferring Opti/RenoDX/Upstream on native-DLSS titles and warning on Force Feeder is right — the Feeder is the fallback, not the default, and the tool has never said so clearly enough. The honest Present-versus-early-color status chip is also good; users currently have no way to tell which route they ended up on.
Suggested order: #58 → #57 → #59 → (upstream #76 lands) → #61, each rebased to its own diff. |
Install only logs a printed instruction (setup_tip); game configs stay untouched per review on faisalkindi#61. Co-authored-by: Cursor <cursoragent@cursor.com>
Follow-up: no Engine.ini writesPer your review — this tool no longer touches the game''s
Agree on merge order: #58 → #57 → #59 → (Feeder #76 lands) → #61, each rebased to its own diff. Happy to rebase #61 onto main after the stack lands; early_color glue stays gated on upstream Feeder. |
|
That is exactly right, and quickly done — thank you. A printed tip that says what to change and states plainly that the tool does not edit Agreed on the order, and on keeping the Nothing further from me on this one until the stack below it lands. |
Expose Feeder async_feed in Settings/cfg, show an Async ~1f chip when on, and recommend async_feed for Gothic (display lag ~1 frame, not FPS delay). Co-authored-by: Cursor <cursoragent@cursor.com>
|
Thin glue for Feeder async feed + HUD (see Feeder PR #76):
No bundled addon64 — build Feeder |
|
Same position as the
So: keep it in the branch, and when #76 lands and a release ships with The "Async ~1f" chip and the Gothic tip are good — being explicit that it is roughly one frame of lag rather than an FPS cost is the right framing, and it is the kind of thing users otherwise learn by guessing. Still nothing further from me here until #58 → #57 → #59 have landed. |
Summary
r.AntiAliasingMethod=0Engine.ini hints; ME/Gothic/Sims tightenengine_velocity=0for estimated-MV/OFAearly_color/early_color_candin feeder_cfg + overrides; Games/Setup status chip (Early color / Present). No bundled.addon64Stack note
Based on
pr/shipping-game-overrides(#59) so this PR currently includes the #57→#58→#59 tip plus one Phase 0 commit. After #59 merges, rebase onto main for a one-commit review. Avoids the hub monolith/preview/assets/patchesaddon64 bloat.Companion Feeder work: jlrouzies-fr/DLSS5-Feeder#76 (early color hunter on the Optimize branch).
Test plan
engine_velocity=0, OFA/LightStab seedsearly_color=1seed; Games chip shows Early color; Feeder overlay can still fallback Presentearly_color=0, estimated-MV friendly; no early claimcargo fmt/clippy -D warnings/cargo testassets/patches/*.addon64Game matrix