backend: Integrate fix for ISO value scaling in dataset metadata#555
Merged
Conversation
Collaborator
Author
Collaborator
Author
|
As discussed in the 2024-04-09 core team meeting, we'll have Sonny test this PR after merging, as part of testing of the v2025.0.0-alpha.0 prerelease. So I'll merge this PR now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #524 by integrating PlanktoScope/device-backend#77 into the master branch for the v2025.0.0 release cycle.
Manual test instructions:
Acquire various test datasets with a few different ISO settings. Check the
metadata.jsonfiles of the resulting datasets to confirm that the values of theiracq_camera_isofield exactly match the actual ISO settings used.Note that certain other metadata fields should be missing or invalid if frontend: Fix the dashboard's metadata-saving regression #550 has not yet been integrated into this PR (e.g. via merging into the master branch). For example,
acq_imaged_volumewill probably beNaNhere.TODOs: