Skip to content

backend: Integrate fix for ISO value scaling in dataset metadata#555

Merged
ethanjli merged 4 commits into
masterfrom
fix/iso-metadata
Apr 9, 2025
Merged

backend: Integrate fix for ISO value scaling in dataset metadata#555
ethanjli merged 4 commits into
masterfrom
fix/iso-metadata

Conversation

@ethanjli

@ethanjli ethanjli commented Apr 2, 2025

Copy link
Copy Markdown
Collaborator

This PR fixes #524 by integrating PlanktoScope/device-backend#77 into the master branch for the v2025.0.0 release cycle.

Manual test instructions:

  • Acquire various test datasets with a few different ISO settings. Check the metadata.json files of the resulting datasets to confirm that the values of their acq_camera_iso field exactly match the actual ISO settings used.

    Note that certain other metadata fields should be missing or invalid if frontend: Fix the dashboard's metadata-saving regression #550 has not yet been integrated into this PR (e.g. via merging into the master branch). For example, acq_imaged_volume will probably be NaN here.

TODOs:

  • (Ethan) Test the resulting adafruithat OS image (bookworm-based)
  • (Sonny) Test the resulting planktoscopehat OS image (bookworm-based)

@ethanjli ethanjli marked this pull request as ready for review April 2, 2025 21:59
@ethanjli ethanjli requested a review from sonnyp April 2, 2025 21:59
@ethanjli

ethanjli commented Apr 3, 2025

Copy link
Copy Markdown
Collaborator Author

Note: #560 has now integrated the code change made by this PR, so now this PR is basically just a CHANGELOG.md update. I'm still going to wait for testing feedback from @sonnyp before I merge this PR, just in case further code changes/fixes are needed for planktoscopehat.

@ethanjli

ethanjli commented Apr 9, 2025

Copy link
Copy Markdown
Collaborator Author

As discussed in the 2024-04-09 core team meeting, we'll have Sonny test this PR after merging, as part of testing of the v2025.0.0-alpha.0 prerelease. So I'll merge this PR now.

@ethanjli ethanjli added this pull request to the merge queue Apr 9, 2025
Merged via the queue into master with commit afe81d1 Apr 9, 2025
@ethanjli ethanjli deleted the fix/iso-metadata branch April 9, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

backend/hardware-controller: ISO isn't saved correctly in the metadata

1 participant