Conversation
| backfill_run.amount_of_elements | ||
| ) if backfill_run.amount_of_elements.present? && | ||
| backfill_run.amount_of_elements > 0 | ||
| if backfill_run.amount_of_elements.present? && |
There was a problem hiding this comment.
I guess some formatting rules?
| module DataDrip | ||
| class Dripper < ActiveJob::Base | ||
| queue_as :data_drip | ||
| queue_as :within_24_hours |
There was a problem hiding this comment.
@sizief do we need to port anything else from the base job in the monorepo?
There was a problem hiding this comment.
Can we make this value configurable at lib/datadrip.rb? Outside factorial this queue name doesn't make a lot of sense
|
@oriolgual this CI is needed to compile and publish the gem? Or it is just for validation? cc @Avalonvdhorst |
It's just for validation, the gem is not published yet |
|
Oriol mentioned since this is an open source project, and the SLO system is internal for factorial, that we need to make the queue name configurable and override that in our deployments. |
3 participants
🚪 Why?
We want to simplify the queue system, so that later we can decouple redis instances per domain.
🔑 What?
Instead of dedicated data_drip queues, we use the 24h ones.
🏡 Context