spdl: require strict zip calls (#1660) - #1660
Merged
Merged
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@moto-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D121805785. |
Summary: Pass an explicit strict argument to every Python zip call in SPDL code, tests, and documentation. Use strict=True for equal-length invariants so mismatches fail instead of silently truncating, and use strict=False where truncation is intentional. Document the convention in the code-authoring guide. Differential Revision: D121805785
meta-codesync
Bot
changed the title
meta-codesync
Bot
force-pushed
the
export-D121805785
branch
from
September 25, 2026 19:51
c3c24ef to
a0d9469
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Pass an explicit strict argument to every Python zip call in SPDL code, tests, and documentation. Use strict=True for equal-length invariants so mismatches fail instead of silently truncating, and use strict=False where truncation is intentional. Document the convention in the code-authoring guide.
Differential Revision: D121805785