Repository navigation
Consolidate async callable detection - #1659
Merged
Merged
Conversation
Summary: Centralize detection of callable objects, coroutine callables, async-generator callables, and either async callable kind in spdl.pipeline._common._convert. Reuse those helpers in conversion, path-variant router dispatch, pipeline definition validation, and fused-region thread accounting so callable instances with async __call__ methods are handled consistently. Differential Revision: D121805543
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@moto-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D121805543. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Centralize detection of callable objects, coroutine callables, async-generator callables, and either async callable kind in spdl.pipeline._common._convert. Reuse those helpers in conversion, path-variant router dispatch, pipeline definition validation, and fused-region thread accounting so callable instances with async call methods are handled consistently.
Differential Revision: D121805543