Closed
Conversation
Summary: Sync KL-Shampoo implementation to OSS. Also, add KL-Shampoo reference to README. **Original summary:** Adding a simplified version of [KL-Shampoo](https://arxiv.org/abs/2509.03378). The main difference to the algorithm presented in the paper is that here only the update of the factor matrices is adjusted, but the eigenvalue correction to the individual factor matrices is not implemented. This correction can also be used for regular Shampoo and will be added in the future. KL-Shampoo is implemented by storing either the inverse root matrices directly, or storing the eigendecompositions of the factor matrices, analogous to regular Shampoo. Reviewed By: hjmshi Differential Revision: D89193149
ed854ba to
9e17827
Compare
|
This pull request has been merged in 89f00f7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Sync KL-Shampoo implementation to OSS. Also, add KL-Shampoo reference to README.
Differential Revision: D89193149