Conversation
facebook-github-bot
added
the
CLA Signed
ppwwyyxx
reviewed
Feb 14, 2022
Comment on lines
+261
to
+263
| if "r" in mode: | ||
| local_path = self._get_local_path(path) | ||
| return open(local_path, mode) |
Contributor
There was a problem hiding this comment.
It should use blob.open instead of caching. Caching has the side effect that it may fill up the disk space, so it's not a good idea to transparently apply caching when reading. Instead, users should explicit call for caching if needed, by using get_local_path.
We apply this strategy to some internal storage backends as well.
Author
|
I ended up using a fork and de-prioritizing making this PR, but we have been using this code for months and I figured I'd finish this PR to share it with everyone else :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a GCS file handler, similar to one in S3.
Test plan
Wrote a test for it, and ran it on my setup. I also used this in a multi-threaded environment with torch DDP and indeed it works :)