Conversation
rayg1234
requested review from
lbluque and
mshuaibii
and removed request for
lbluque
August 26, 2026 00:22
lbluque
previously approved these changes
Aug 26, 2026
lbluque
left a comment
lbluque
left a comment
Contributor
There was a problem hiding this comment.
Minor comments and questions!
| warmup_steps: int = 10, | ||
| workers: int = 0, | ||
| workers_per_node: int = 8, | ||
| gp_config: GraphParallelConfig | dict | None = None, |
Contributor
There was a problem hiding this comment.
allowing dicts is for backwards compat?
| self.model_name = model_name | ||
| self.workers = workers | ||
| self.workers_per_node = workers_per_node | ||
| self.gp_config = gp_config |
Contributor
There was a problem hiding this comment.
Can we turn raw dicts into GPConfigs here to keep only that code path?
Comment on lines
+471
to
+473
| sys.executable, | ||
| "-m", | ||
| "ray.scripts.scripts", |
Contributor
There was a problem hiding this comment.
Just curious why the switch directly to source rather than the cli entrypoint?
Comment on lines
771
to
773
| bundle = {"CPU": workers} | ||
| if device == "cuda": | ||
| bundle["GPU"] = workers |
Contributor
There was a problem hiding this comment.
Question, why always 1:1 CPU to GPU ratio here?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
STRICT_SPREADplacement group and pin bundle 0 to the driver node, preventing duplicate physical GPU assignmentsValidation
pre-commit run --fileson all six modified source filesTargeted pytest tests were not run because pytest is not installed in the available fairchem virtual environment.