Skip to content

Generate and persist UMA model IDs - #2163

Open
lbluque wants to merge 3 commits into
mainfrom
auto-uma-model-ids
Open

lbluque wants to merge 3 commits into
mainfrom
auto-uma-model-ids

Conversation

@lbluque

@lbluque lbluque commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • generate random IDs for untagged UMA MoE models
  • broadcast generated IDs from rank zero across distributed workers
  • persist resolved IDs in resume, DCP, and inference checkpoint configs
  • add IDs to UMA benchmark configs
  • add coverage for generation, broadcasting, and checkpoint persistence

Testing

  • 33 focused unit tests passed
  • DCP train/save/load integration test passed
  • pre-commit passed

@meta-cla meta-cla Bot added the cla signed label Aug 13, 2026
@lbluque lbluque added bug Something isn't working patch Patch version release labels Aug 13, 2026
@lbluque
lbluque requested a review from wood-b August 13, 2026 18:00

@wood-b wood-b left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good, I just need a bit more time to think about the changes to compat.py

tasks: ${tasks}
model:
_target_: fairchem.core.models.base.HydraModel
model_id: UMA-S-1.2

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to add the model here? I don't love hard coding a model. Also if we do, it should be UMA-S-1.2.1

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is just setting a model_id for the purpose of testing training. It could be whatever. I changed it to "UMA-s-test" to be descriptive

Comment thread configs/uma/benchmark/perf_check/training_inner_2x.yaml Outdated
@lbluque
lbluque requested a review from wood-b August 20, 2026 21:46
@github-actions

Copy link
Copy Markdown

This PR has been marked as stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale label Sep 25, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cla signed patch Patch version release stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants