Repository navigation
Conversation
SciPy's sph_harm_y expects the polar angle before the azimuthal angle. Add degree-one value checks so future convention changes cannot pass with only shape and Y_0^0 coverage.
|
What are the implications of the bug? Was #1717 correct that this file isn't currently referenced/used in the main branch? |
Contributor
Author
|
A quick search reveals that nothing depends on this code. Another option would be to remove the code completely. |
Contributor
|
@bkmi Where are we using this in the codebase? |
Contributor
Author
|
like I said above, we do not use it in the codebase |
Might be simpler to just remove it. This would I believe also avoid the need to pin scipy 1.17 |
|
This PR has been marked as stale because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SciPy's sph_harm_y expects the polar angle before the azimuthal angle. Add degree-one value checks so future convention changes cannot pass with only shape and Y_0^0 coverage.
Thanks @TyBalduf
https://github.com/facebookresearch/fairchem/pull/1736/changes#r3770224272