This repository was archived by the owner on Oct 31, 2023. It is now read-only.
use curl for uploading models#79
Open
gwenzek wants to merge 1 commit into
Open
Conversation
Conflicts: dynalab_cli/upload.py Regression: this is not handling 429 anymore
facebook-github-bot
added
the
CLA Signed
douwekiela
reviewed
Jun 9, 2021
| auth_header = AccessToken().get_headers()["Authorization"] | ||
| res = subprocess.check_output( | ||
| [ | ||
| "curl", |
There was a problem hiding this comment.
Do we just assume everyone has curl installed?
|
Did you see the same issue with prod server (or flores dev server), or just in local testing? |
|
#92 should fix the issue both for locally test upload, and uploading large files, using requests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For me uploading models using the
requestAPI doesn't work. I think this may be related to the size of the models.Using Curl instead works fine
Here is the log that I see when trying to upload a big model:
I'd be curious to see if there is a better solution. In particular the curl version doesn't handle 429 errors anymore.