Generalize Euler odd-parts identity to commutative rings - #6
Open
faabian wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the unnecessary NoZeroDivisors hypothesis from prop.gf.prod.euler-odd. Instead of invoking the generating-series form of Glaisher's theorem, whose Mathlib proof uses cancellation, this derives the required series equality coefficientwise from Mathlib's unrestricted cardinality theorem Nat.Partition.card_restricted_eq_card_countRestricted and casts it into the coefficient ring.\n\nValidation:\n- lake build AlgebraicCombinatorics.FPS.InfiniteProducts2\n- full lake build (8,078 jobs)\n- #print axioms euler_odd_parts_identity: only propext, Classical.choice, Quot.sound\n\nNo sorry is introduced.