This repository was archived by the owner on Apr 28, 2023. It is now read-only.
[DO NOT MERGE] attempt at reproducing error#458
Open
skimo-openhub wants to merge 4 commits intomasterfrom
Open
[DO NOT MERGE] attempt at reproducing error#458skimo-openhub wants to merge 4 commits intomasterfrom
skimo-openhub wants to merge 4 commits intomasterfrom
Conversation
added 3 commits
May 29, 2018 08:59
isl does not currently perform any operations lazily, so a potentially large product map would get created even if only a very small part of it will actually get used. Intersect domain and range directly instead.
…functions Store this mapping in addition to the filter derived from the mapping. The mapping is needed in the next commit. The mapping is constructed in ScheduleTree::makeMappingFilter and passed to the ScheduleTreeElemMappingFilter constructor. Some of the sanity checks are therefore moved from the constructor to ScheduleTree::makeMappingFilter.
In particular, use mappings to threads and warps to determine whether all dependences are within a thread or warp. Do so instead of considering pairs of thread identifier parameters. Duplicating thread identifier parameters is confusing at best and relies on renaming parameters, which is frowned upon and which will not be exported in the mainline isl C++ interface. Duplicate parameters are confusing because there is only one value for any given thread identifier at a given point in the execution. Furthermore, the filter assigning the thread mapping to parameters is only relevant during AST generation. Prior to that, it is more natural to think in terms of the thread mapping itself. This is what this commit does. It is not only simpler, but also shorter. It is not entirely clear why the intersection with the context is needed, but this is what the original code does and it is preserved by this commit.
skimo-openhub
force-pushed
the
test/attempt
branch
from
4a5beb0 to
a9d8476
Compare
skimo-openhub
force-pushed
the
test/attempt
branch
from
a9d8476 to
6dc1fbc
Compare
|
Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired. Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
1 similar comment
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.