Skip to content

Fix mock_services linking in self-contained build #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
excelle08 wants to merge 1 commit into
base: v2-beta
Choose a base branch
from
Open

Fix mock_services linking in self-contained build #837

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/feedsim/third_party/src/workloads/ranking/mock_services/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,12 @@ target_link_libraries(mock_services
# is a no-op. See the --gc-sections comment on the compile
# options below for the CentOS path.
${LIBURING_LIBRARY}
# gflags: folly/glog use DEFINE_FLAG macros which reference
# google::FlagRegisterer. LeafNodeRank/DriverNodeRank link GFLAGS_TARGET
# (gflags_static for self-contained builds, gflags for traditional).
# mock_services was missing it, causing "undefined reference to
# FlagRegisterer" on static-link aarch64 builds.
${GFLAGS_TARGET}
)
target_compile_options(mock_services PUBLIC
-fno-omit-frame-pointer
Expand Down
Loading