Skip to content

Improve FeedSim build parallelism on Ubuntu #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LDong-Arm wants to merge 1 commit into
base: v2-beta
Choose a base branch
from
Open

Improve FeedSim build parallelism on Ubuntu #823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions packages/feedsim/install_feedsim_aarch64_ubuntu.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ if ! [ -d "fast_float" ]; then
cd fast_float
mkdir build && cd build
cmake ..
make
make -j"$(nproc)"
make install
cd ../../
fi
Expand Down Expand Up @@ -125,7 +125,7 @@ if ! [ -d "gflags-2.2.2" ]; then
cd "gflags-2.2.2"
mkdir -p build && cd build
cmake -DBUILD_SHARED_LIBS=ON -DBUILD_TESTING=OFF -DCMAKE_BUILD_TYPE=Release ../
make -j8
make -j"$(nproc)"
make install
cd ../../
else
Expand All @@ -139,7 +139,7 @@ if ! [ -d "glog-0.4.0" ]; then
cd "glog-0.4.0"
mkdir -p build && cd build
cmake -DBUILD_SHARED_LIBS=ON -DBUILD_TESTING=OFF -DCMAKE_BUILD_TYPE=Release ../
make -j8
make -j"$(nproc)"
make install
cd ../../
else
Expand Down Expand Up @@ -331,7 +331,15 @@ cmake -G Ninja \
-DTorch_DIR="${FEEDSIM_THIRD_PARTY_SRC}/libtorch/share/cmake/Torch" \
../

ninja -v -j1
# Third-party deps (fmt, folly, fizz, wangle, mvfst, fbthrift) are built by this
# ninja step via ExternalProject_Add. Their build order is declared in
# third_party/src/CMake/build-*.cmake via add_dependencies() and
# ExternalProject_Add_StepDependencies(), so ninja respects the DAG under -jN.
# Use nproc/2 to avoid OOM during heavy template-instantiation steps.
NINJA_JOBS="${BP_NINJA_JOBS:-$(( $(nproc) / 2 ))}"
[ "$NINJA_JOBS" -lt 1 ] && NINJA_JOBS=1
msg "Building FeedSim with ninja -j${NINJA_JOBS} (set BP_NINJA_JOBS to override)"
ninja -j"${NINJA_JOBS}"

msg ""
msg "=== FeedSim Installation Complete ==="
Expand Down
16 changes: 12 additions & 4 deletions packages/feedsim/install_feedsim_ubuntu.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ if ! [ -d "fast_float" ]; then
cd fast_float
mkdir build && cd build
cmake ..
make
make -j"$(nproc)"
make install
cd ../../
fi
Expand Down Expand Up @@ -155,7 +155,7 @@ if ! [ -d "gflags-2.2.2" ]; then
cd "gflags-2.2.2"
mkdir -p build && cd build
cmake -DBUILD_SHARED_LIBS=ON -DBUILD_TESTING=OFF -DCMAKE_BUILD_TYPE=Release -DCMAKE_POLICY_VERSION_MINIMUM=3.5 ../
make -j8
make -j"$(nproc)"
make install
cd ../../
else
Expand All @@ -169,7 +169,7 @@ if ! [ -d "glog-0.4.0" ]; then
cd "glog-0.4.0"
mkdir -p build && cd build
cmake -DBUILD_SHARED_LIBS=ON -DBUILD_TESTING=OFF -DCMAKE_BUILD_TYPE=Release -DCMAKE_POLICY_VERSION_MINIMUM=3.5 ../
make -j8
make -j"$(nproc)"
make install
cd ../../
else
Expand Down Expand Up @@ -326,7 +326,15 @@ cmake -G Ninja \
-DCMAKE_PREFIX_PATH="${FEEDSIM_THIRD_PARTY_SRC}/libtorch" \
../

ninja -v -j1
# Third-party deps (fmt, folly, fizz, wangle, mvfst, fbthrift) are built by this
# ninja step via ExternalProject_Add. Their build order is declared in
# third_party/src/CMake/build-*.cmake via add_dependencies() and
# ExternalProject_Add_StepDependencies(), so ninja respects the DAG under -jN.
# Use nproc/2 to avoid OOM during heavy template-instantiation steps.
NINJA_JOBS="${BP_NINJA_JOBS:-$(( $(nproc) / 2 ))}"
[ "$NINJA_JOBS" -lt 1 ] && NINJA_JOBS=1
msg "Building FeedSim with ninja -j${NINJA_JOBS} (set BP_NINJA_JOBS to override)"
ninja -j"${NINJA_JOBS}"

msg ""
msg "=== FeedSim Installation Complete ==="
Expand Down
Loading