Add CodeQL workflow to fix Analyze (java-kotlin) CI failure#720
Open
CatherineGasnier wants to merge 1 commit intofacebookincubator:mainfrom
Open
Add CodeQL workflow to fix Analyze (java-kotlin) CI failure#720CatherineGasnier wants to merge 1 commit intofacebookincubator:mainfrom
CatherineGasnier wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
Summary: The "Analyze (java-kotlin)" GitHub Actions check was failing because GitHub's organization-level CodeQL default setup uses autobuild for Java/Kotlin analysis. The Glean repo's Java/Kotlin code (indexer code, test cases) uses Buck as its build system and cannot be compiled by CodeQL's autobuild, causing the analysis to consistently fail. The thrift/Haskell changes in D94378719 did not cause this failure - it is a pre-existing issue with the CodeQL default setup configuration that was correlated with D94378719 by timing. This diff adds a custom CodeQL workflow that: - Explicitly configures java-kotlin analysis with `build-mode: none`, which performs source-only analysis without requiring compilation - Replaces the failing org-level CodeQL default setup for java-kotlin - Follows the same pattern used by other Meta open source repos (pytorch/text, ttpforge) to customize CodeQL analysis The workflow file is placed at `.github/workflows/codeql.yml` in the ShipIt-exported GitHub repo structure (`fbcode/glean/github/tld/`). [Session trajectory link](https://www.internalfb.com/intern/devai/devmate/inspector/?id=cbf8a985-5c99-403a-80c3-8f678e2cfa4f) Differential Revision: D96743566
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@CatherineGasnier has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96743566. |
✅ Deploy Preview for fb-oss-glean canceled.
|
Author
|
This is and AI generated attempt to fix https://github.com/facebookincubator/Glean/actions/runs/22642802765/job/65623019888 Waiting for CI... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The "Analyze (java-kotlin)" GitHub Actions check was failing because GitHub's organization-level CodeQL default setup uses autobuild for Java/Kotlin analysis. The Glean repo's Java/Kotlin code (indexer code, test cases) uses Buck as its build system and cannot be compiled by CodeQL's autobuild, causing the analysis to consistently fail.
The thrift/Haskell changes in D94378719 did not cause this failure - it is a pre-existing issue with the CodeQL default setup configuration that was correlated with D94378719 by timing.
This diff adds a custom CodeQL workflow that:
build-mode: none, which performs source-only analysis without requiring compilationThe workflow file is placed at
.github/workflows/codeql.ymlin the ShipIt-exported GitHub repo structure (fbcode/glean/github/tld/).Session trajectory link
Differential Revision: D96743566