This repository was archived by the owner on May 1, 2020. It is now read-only.
Update the build#72
Open
Jawnnypoo wants to merge 3 commits intofacebookarchive:masterfrom
Jawnnypoo:update_build
Open
Update the build#72Jawnnypoo wants to merge 3 commits intofacebookarchive:masterfrom Jawnnypoo:update_build
Jawnnypoo wants to merge 3 commits intofacebookarchive:masterfrom
Jawnnypoo:update_build
Conversation
…reak builds which try to compile with Java 8
Author
Do you guys have any ideas as to why this is needed or why this was not an issue before? It may have just been an issue for me, since I have JDK 8 installed and maybe Android Studio was just compiling to the latest. Regardless, I think it would be nice to have this in here explicit for anyone else who might run into this issue. I suppose others were encountering it, after seeing issue #71 |
Author
|
@willbailey Any chance of reviewing this? It is an issue any developer who wants to make updates will probably run into. Case in point, #77 already repeats some of the work done here. Is this library still being maintained? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just wanted to make this easier for the next person who pulls down the repo and wants to build.
Bump build tools, target sdk, and target Java 7 so that it does not break builds which try to compile with Java 8 (which is what Android Studio was trying to compile with by default for me)
This will also allow for users to use newer features like instant run when developing. Always a plus!