This repository was archived by the owner on May 1, 2020. It is now read-only.
Open
Conversation
A better code structure and API downgraded to 14
I have changed a lot of things there, the most one is about compatibility with API 14
Changes on Example structure and some corrections at PlaygroundActivity
Structure changes
Contributor
|
Still need to remove the butterknife dependency if you want to land this |
Contributor
Author
|
@willbailey This will be automatically removed when you merge #58? If not, sorry for this issues... |
Contributor
Author
|
@willbailey Well, I'll do that change, but isn't better to wait to merge #58 firstly? |
Contributor
|
I think landing the API downgrade first is the way to go. I'm not sure I understand the goal of #58, but lowering the API bar does seem like a nice improvement. |
ghost
added
the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created this new branch only to downgrade de API 14. Waiting the verify and merge of #58