Skip to content

Fix VSCode extension build after vscode-languageclient update#189

Open
abhinavgautam01 wants to merge 1 commit intofacebook:mainfrom
abhinavgautam01:fix/vscode-build-broken
Open

Fix VSCode extension build after vscode-languageclient update#189
abhinavgautam01 wants to merge 1 commit intofacebook:mainfrom
abhinavgautam01:fix/vscode-build-broken

Conversation

@abhinavgautam01
Copy link
Copy Markdown

Fixes #153.

This PR fixes the VSCode extension TypeScript build break caused by a version mismatch between vscode-languageclient v9 and older VSCode type definitions.

What changed

  • Switched language client import to Node entrypoint:
  • vscode/client/src/extension.ts
  • from 'vscode-languageclient/node'
  • Updated VSCode API/type alignment:
  • vscode/client/package.json
  • @types/vscode → 1.82.0
  • engines.vscode → ^1.82.0
  • vscode/package.json
  • engines.vscode → ^1.82.0
  • Updated lockfiles:
  • vscode/client/package-lock.json
  • vscode/package-lock.json

Validation

  • cd vscode && npm run compile passes
  • cargo clippy
  • cargo build
  • cargo test
  • cargo bench

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 2, 2026
@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented May 2, 2026

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D103524557. (Because this pull request was imported automatically, there will not be any future comments.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VSCode extension build broken

1 participant