Fix parameter type checking for unassigned/optional arguments#185
Fix parameter type checking for unassigned/optional arguments#185Inconnu08 wants to merge 1 commit intofacebook:mainfrom
Conversation
|
Hi @Inconnu08! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
d95a767 to
7e6d7f7
Compare
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D103344457. (Because this pull request was imported automatically, there will not be any future comments.) |
Fixes an issue in
check_parameter_typeswhere unassigned parameterswith type annotations could trigger a panic.
Previously:
Nonevalues fromget_slotcaused a panicNow:
All relevant tests pass.
Resolves #182