Skip to content

Fix parameter type checking for unassigned/optional arguments#185

Open
Inconnu08 wants to merge 1 commit intofacebook:mainfrom
Inconnu08:fix/typecheck-parameter-handling
Open

Fix parameter type checking for unassigned/optional arguments#185
Inconnu08 wants to merge 1 commit intofacebook:mainfrom
Inconnu08:fix/typecheck-parameter-handling

Conversation

@Inconnu08
Copy link
Copy Markdown

Fixes an issue in check_parameter_types where unassigned parameters
with type annotations could trigger a panic.

Previously:

  • None values from get_slot caused a panic
  • This broke the expected behavior for optional or unassigned parameters

Now:

  • Unassigned parameters are handled gracefully
  • Type checking is only applied when a value is present

All relevant tests pass.

Resolves #182

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented May 1, 2026

Hi @Inconnu08!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@Inconnu08 Inconnu08 force-pushed the fix/typecheck-parameter-handling branch from d95a767 to 7e6d7f7 Compare May 1, 2026 04:32
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 1, 2026
@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented May 1, 2026

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D103344457. (Because this pull request was imported automatically, there will not be any future comments.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Runtime type checking broken for *args and **kwargs

1 participant