Skip to content

Update mt_app_install.md (+1 more) for fbcode/openzl/dev/.llms, www/flib/meta_account/entity/application/install/.llms #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
meta-codesync wants to merge 1 commit into
base: dev
Choose a base branch
from
+3 −2
Open

Update mt_app_install.md (+1 more) for fbcode/openzl/dev/.llms, www/flib/meta_account/entity/application/install/.llms #844

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .claude/skills/openzl-codec-design/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,10 +177,11 @@ See `cpp/include/openzl/cpp/codecs/Zigzag.hpp` for a simple example, `cpp/includ
1. Add `#include "openzl/codecs/{codec}/encode_{codec}_binding.h"`
2. Add entry to `ER_standardNodes[]`:
```c
REGISTER_TRANSFORM(ZL_StandardNodeID_{codec}, ZL_StandardTransformID_{codec}, ZL_MAX_FORMAT_VERSION, EI_CODEC),
// REGISTER_TRANSFORM(NodeID, TransformID, minFormatVer, minLibraryVer, EI_MACRO)
REGISTER_TRANSFORM(ZL_StandardNodeID_{codec}, ZL_StandardTransformID_{codec}, 26, 202, EI_CODEC),
```

NOTE: Do not use the macro `ZL_MAX_FORMAT_VERSION`, use the current value of that macro! This value tells OpenZL the minimum format version that is required to use this codec, which for new codecs is the current maximum format version.
NOTE: Hard-code the **current numeric values** of `ZL_MAX_FORMAT_VERSION` and `ZL_LIBRARY_VERSION_NUMBER` (e.g., `26, 202`) — do NOT pass the macros themselves. These pin the minimum format/library version required to use this codec; using the macros would silently widen support every time they bump (see `ACR_explicit_format_version_in_registrations`).

### Decoder Registry (`src/openzl/codecs/decoder_registry.c`)

Expand Down
Loading