Skip to content

Add keyboard navigation tests (#829)#829

Closed
jlee303 wants to merge 3 commits into
facebook:devfrom
jlee303:export-D109043852
Closed

Add keyboard navigation tests (#829)#829
jlee303 wants to merge 3 commits into
facebook:devfrom
jlee303:export-D109043852

Conversation

@jlee303

@jlee303 jlee303 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Summary:

  • Add tests for keyboard navigation
  • Update utils file to include helper functions needed by keyboard navigation tests

Reviewed By: Victor-C-Zhang

Differential Revision: D109043852

@meta-codesync

meta-codesync Bot commented Jun 18, 2026

Copy link
Copy Markdown

@jlee303 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109043852.

jlee303 added a commit to jlee303/openzl-1 that referenced this pull request Jun 18, 2026
Summary:
Pull Request resolved: facebook#829

- Add tests for keyboard navigation
- Update utils file to include helper functions needed by keyboard navigation tests

Differential Revision: D109043852
@jlee303 jlee303 force-pushed the export-D109043852 branch from 8293f61 to 4160d8e Compare June 18, 2026 23:33
@meta-codesync meta-codesync Bot changed the title Add keyboard navigation tests Add keyboard navigation tests (#829) Jun 18, 2026
Jennifer Lee and others added 3 commits July 6, 2026 12:08
Summary:
Pull Request resolved: facebook#824

Expanded existing streamdump visualizer tests, added codecdag/chunk graph tests.
Fixed bug in function graph expands so that diamond shaped graphs will work as expected.
- Include all parents when expanding/collapsing graph
- Updated visited set
- Updated buck so that tests actually run in diff

Differential Revision: D108782795
Summary:
Pull Request resolved: facebook#827

- Add unit tests for StreamdumpGraphController and LayoutController.
- Add shared test helpers in mockGraphNodes.ts and updated createTestModels.ts fixture to expose underlying raw Streamdump

Differential Revision: D108940518
Summary:
Pull Request resolved: facebook#829

- Add tests for keyboard navigation
- Update utils file to include helper functions needed by keyboard navigation tests

Reviewed By: Victor-C-Zhang

Differential Revision: D109043852
@jlee303 jlee303 force-pushed the export-D109043852 branch from 4160d8e to 93dddd4 Compare July 6, 2026 19:30
@meta-codesync meta-codesync Bot closed this in b43a9d5 Jul 6, 2026
@meta-codesync meta-codesync Bot added the Merged label Jul 6, 2026
@meta-codesync

meta-codesync Bot commented Jul 6, 2026

Copy link
Copy Markdown

This pull request has been merged in b43a9d5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant