Add controller tests (#827)#827
Closed
jlee303 wants to merge 2 commits into
Closed
Conversation
|
@jlee303 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D108940518. |
jlee303
added a commit
to jlee303/openzl-1
that referenced
this pull request
Jun 18, 2026
Summary: Pull Request resolved: facebook#827 - Add unit tests for StreamdumpGraphController and LayoutController. - Add shared test helpers in mockGraphNodes.ts and updated createTestModels.ts fixture to expose underlying raw Streamdump Differential Revision: D108940518
jlee303
force-pushed
the
export-D108940518
branch
from
4e07611 to
aaa21d1
Compare
jlee303
added a commit
to jlee303/openzl-1
that referenced
this pull request
Jun 18, 2026
Summary: Pull Request resolved: facebook#827 - Add unit tests for StreamdumpGraphController and LayoutController. - Add shared test helpers in mockGraphNodes.ts and updated createTestModels.ts fixture to expose underlying raw Streamdump Differential Revision: D108940518
jlee303
force-pushed
the
export-D108940518
branch
from
aaa21d1 to
d916986
Compare
jlee303
added a commit
to jlee303/openzl-1
that referenced
this pull request
Jun 18, 2026
Summary: Pull Request resolved: facebook#827 - Add unit tests for StreamdumpGraphController and LayoutController. - Add shared test helpers in mockGraphNodes.ts and updated createTestModels.ts fixture to expose underlying raw Streamdump Differential Revision: D108940518
jlee303
force-pushed
the
export-D108940518
branch
from
d916986 to
04a46ac
Compare
jlee303
pushed a commit
to jlee303/openzl-1
that referenced
this pull request
Jun 18, 2026
Summary: Pull Request resolved: facebook#827 - Add unit tests for StreamdumpGraphController and LayoutController. - Add shared test helpers in mockGraphNodes.ts and updated createTestModels.ts fixture to expose underlying raw Streamdump Differential Revision: D108940518
jlee303
added a commit
to jlee303/openzl-1
that referenced
this pull request
Jun 18, 2026
Summary: Pull Request resolved: facebook#827 - Add unit tests for StreamdumpGraphController and LayoutController. - Add shared test helpers in mockGraphNodes.ts and updated createTestModels.ts fixture to expose underlying raw Streamdump Differential Revision: D108940518
jlee303
force-pushed
the
export-D108940518
branch
from
04a46ac to
7a6aa05
Compare
jlee303
added a commit
to jlee303/openzl-1
that referenced
this pull request
Jun 18, 2026
Summary: Pull Request resolved: facebook#827 - Add unit tests for StreamdumpGraphController and LayoutController. - Add shared test helpers in mockGraphNodes.ts and updated createTestModels.ts fixture to expose underlying raw Streamdump Differential Revision: D108940518
jlee303
force-pushed
the
export-D108940518
branch
from
7a6aa05 to
1baeee8
Compare
Summary: Pull Request resolved: facebook#824 Expanded existing streamdump visualizer tests, added codecdag/chunk graph tests. Fixed bug in function graph expands so that diamond shaped graphs will work as expected. - Include all parents when expanding/collapsing graph - Updated visited set - Updated buck so that tests actually run in diff Differential Revision: D108782795
Summary: Pull Request resolved: facebook#827 - Add unit tests for StreamdumpGraphController and LayoutController. - Add shared test helpers in mockGraphNodes.ts and updated createTestModels.ts fixture to expose underlying raw Streamdump Reviewed By: Victor-C-Zhang Differential Revision: D108940518
jlee303
pushed a commit
to jlee303/openzl-1
that referenced
this pull request
Jul 6, 2026
Summary: Pull Request resolved: facebook#827 - Add unit tests for StreamdumpGraphController and LayoutController. - Add shared test helpers in mockGraphNodes.ts and updated createTestModels.ts fixture to expose underlying raw Streamdump Differential Revision: D108940518
jlee303
force-pushed
the
export-D108940518
branch
from
1baeee8 to
b8d61d9
Compare
|
This pull request has been merged in 78c10a0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Reviewed By: Victor-C-Zhang
Differential Revision: D108940518