Skip to content

Update existing tests & add codec dag tests (#824)#824

Closed
jlee303 wants to merge 1 commit into
facebook:devfrom
jlee303:export-D108782795
Closed

Update existing tests & add codec dag tests (#824)#824
jlee303 wants to merge 1 commit into
facebook:devfrom
jlee303:export-D108782795

Conversation

@jlee303

@jlee303 jlee303 commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Summary:

Expanded existing streamdump visualizer tests, added codecdag/chunk graph tests.
Fixed bug in function graph expands so that diamond shaped graphs will work as expected.

  • Include all parents when expanding/collapsing graph
  • Updated visited set
  • Updated buck so that tests actually run in diff

Reviewed By: Victor-C-Zhang

Differential Revision: D108782795

@meta-cla meta-cla Bot added the cla signed label Jun 17, 2026
@meta-codesync

meta-codesync Bot commented Jun 17, 2026

Copy link
Copy Markdown

@jlee303 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D108782795.

@meta-codesync meta-codesync Bot changed the title Update existing tests & add codec dag tests Update existing tests & add codec dag tests (#824) Jun 17, 2026
jlee303 added a commit to jlee303/openzl-1 that referenced this pull request Jun 17, 2026
Summary:

Expanded existing streamdump visualizer tests, added codecdag/chunk graph tests.
Fixed bug in function graph expands so that diamond shaped graphs will work as expected.
- Include all parents when expanding/collapsing graph
- Updated visited set

Differential Revision: D108782795
@jlee303 jlee303 force-pushed the export-D108782795 branch from bf64c44 to b42905d Compare June 17, 2026 22:10
jlee303 added a commit to jlee303/openzl-1 that referenced this pull request Jun 18, 2026
Summary:
Pull Request resolved: facebook#824

Expanded existing streamdump visualizer tests, added codecdag/chunk graph tests.
Fixed bug in function graph expands so that diamond shaped graphs will work as expected.
- Include all parents when expanding/collapsing graph
- Updated visited set
- Updated buck so that tests actually run in diff

Differential Revision: D108782795
@jlee303 jlee303 force-pushed the export-D108782795 branch from b42905d to 3a7ae99 Compare June 18, 2026 21:42
jlee303 pushed a commit to jlee303/openzl-1 that referenced this pull request Jun 18, 2026
Summary:
Pull Request resolved: facebook#824

Expanded existing streamdump visualizer tests, added codecdag/chunk graph tests.
Fixed bug in function graph expands so that diamond shaped graphs will work as expected.
- Include all parents when expanding/collapsing graph
- Updated visited set

Differential Revision: D108782795
jlee303 pushed a commit to jlee303/openzl-1 that referenced this pull request Jun 18, 2026
Summary:
Pull Request resolved: facebook#824

Expanded existing streamdump visualizer tests, added codecdag/chunk graph tests.
Fixed bug in function graph expands so that diamond shaped graphs will work as expected.
- Include all parents when expanding/collapsing graph
- Updated visited set

Differential Revision: D108782795
jlee303 added a commit to jlee303/openzl-1 that referenced this pull request Jun 18, 2026
Summary:
Pull Request resolved: facebook#824

Expanded existing streamdump visualizer tests, added codecdag/chunk graph tests.
Fixed bug in function graph expands so that diamond shaped graphs will work as expected.
- Include all parents when expanding/collapsing graph
- Updated visited set
- Updated buck so that tests actually run in diff

Differential Revision: D108782795
@jlee303 jlee303 force-pushed the export-D108782795 branch from 3a7ae99 to ffb6a32 Compare June 18, 2026 23:33
jlee303 pushed a commit to jlee303/openzl-1 that referenced this pull request Jun 18, 2026
Summary:
Pull Request resolved: facebook#824

Expanded existing streamdump visualizer tests, added codecdag/chunk graph tests.
Fixed bug in function graph expands so that diamond shaped graphs will work as expected.
- Include all parents when expanding/collapsing graph
- Updated visited set
- Updated buck so that tests actually run in diff

Differential Revision: D108782795
Summary:
Pull Request resolved: facebook#824

Expanded existing streamdump visualizer tests, added codecdag/chunk graph tests.
Fixed bug in function graph expands so that diamond shaped graphs will work as expected.
- Include all parents when expanding/collapsing graph
- Updated visited set
- Updated buck so that tests actually run in diff

Reviewed By: Victor-C-Zhang

Differential Revision: D108782795
jlee303 pushed a commit to jlee303/openzl-1 that referenced this pull request Jul 6, 2026
Summary:
Pull Request resolved: facebook#824

Expanded existing streamdump visualizer tests, added codecdag/chunk graph tests.
Fixed bug in function graph expands so that diamond shaped graphs will work as expected.
- Include all parents when expanding/collapsing graph
- Updated visited set
- Updated buck so that tests actually run in diff

Differential Revision: D108782795
@jlee303 jlee303 force-pushed the export-D108782795 branch from ffb6a32 to cffbc93 Compare July 6, 2026 19:23
@meta-codesync meta-codesync Bot closed this in a940869 Jul 6, 2026
@meta-codesync meta-codesync Bot added the Merged label Jul 6, 2026
@meta-codesync

meta-codesync Bot commented Jul 6, 2026

Copy link
Copy Markdown

This pull request has been merged in a940869.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant