[Accton] Fix a bug that benchmark can't run continuous sub-tests.#933
Conversation
|
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Description: This fix can make the benchmark run continuous sub-tests instead of only running them individually. Author: brandon_cheng <brandon_cheng@accton.com>
20de484 to
2033f0a
Compare
Description:
This fix can make the benchmark run continuous sub-tests instead of only running them individually.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runpre-commit run --files fboss/agent/SwSwitch.cpp
pre-commit run --files fboss/lib/restart_tracker/RestartTimeTracker.cpp
Summary
Test Plan
The benchmark, sai_stats_collection_speed-sai_impl, has been tested. With the fix, it can test two sub-tests within it in a test run.
The related post in workplace is https://fb.workplace.com/groups/externalmp3nfbossacctonmeta/permalink/1250282870307419/
And the other benchmark, sai_fsw_scale_route_add_speed-sai_impl, that has only one sub-test, is also tested.