Ladakh800bcls: Platform: Prevent i2c timing issues#932
Draft
chee-zhang wants to merge 1 commit intofacebook:mainfrom
Draft
Ladakh800bcls: Platform: Prevent i2c timing issues#932chee-zhang wants to merge 1 commit intofacebook:mainfrom
chee-zhang wants to merge 1 commit intofacebook:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
This PR is to preload the i2c kmod to prevent the related i2c timing issues.
The
fboss_iob_i2ckmod is added torequiredKmodsToLoadwhich can avoid the conflict of creating i2c bus.For reference
Test Plan
platform_manager.log