[Nexthop] Make component build containers privileged#916
Open
travisb-nexthop wants to merge 2 commits intofacebook:mainfrom
Open
[Nexthop] Make component build containers privileged#916travisb-nexthop wants to merge 2 commits intofacebook:mainfrom
travisb-nexthop wants to merge 2 commits intofacebook:mainfrom
Conversation
Add abstract build component framework for managing build operations. - Implement AbstractComponent base class for build components - Add component lifecycle management (prepare, build, extract) - Integrate with artifact store, download, and execute modules - Enable extensible component-based build architecture Tests utilizing the above infrastructure will be added when component build supports are included.
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. --> **Pre-submission checklist** - [X] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [X] `pre-commit run` <!-- Explain the motivation for making this change and any other context that you think would help reviewers of your code. What existing problem does the pull request solve? --> Some kinds of builds require a privileged containers, such as builds which need to use containers within themselves. Make the component build containers all privileged. This requires making /etc/shadow root-readable because CentOS uses special permission capability overrides to read the file which are not configured in the host user namespace. <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. How exactly did you verify that your PR solves the issue you wanted to solve? --> <!-- If a relevant Github issue exists for this PR, please make sure you link that issue to this PR --> Build the Demo Container other_dependency from facebook#911 which motivated this need.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Some kinds of builds require a privileged containers, such as builds
which need to use containers within themselves.
Make the component build containers all privileged.
This requires making /etc/shadow root-readable because CentOS uses
special permission capability overrides to read the file which are not
configured in the host user namespace.
Test Plan
Build the Demo Container other_dependency from
#911 which motivated this need.