Ladahk800bcls: fix mgmt port issue#915
Open
kaisheng-hua wants to merge 1 commit intofacebook:mainfrom
Open
Conversation
harshitgulati18
approved these changes
Feb 12, 2026
|
@Protick666 has imported this pull request. If you are a Meta employee, you can view this in D93059517. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runclang-format.......................................................................Passed
black................................................(no files to check)Skipped
shellcheck...........................................(no files to check)Skipped
shfmt................................................(no files to check)Skipped
trim trailing whitespace...................................................Passed
fix end of files......................................................................Passed
check yaml...........................................(no files to check)Skipped
check json..............................................................................Passed
check for merge conflicts.................................................Passed
ruff check...........................................(no files to check)Skipped
Summary
Fix issue: Agent is facing a crash if we add management port information form the platform mapping csvs.
Tasks including:
Added profile ID 22 and 23 for mgmt port in port_profile_mapping.csv
Updated the si_settings.csv for mgmt port
Regenerated and updated the platform_mapping.json, also updated the embeded platform_mapping json string in PlatformMapping.cpp
Same as icecube/icetea, fix the function getPhysicalLaneId() to get correct Lane ID for mgmt port
Test Plan
Fixed Agent crash issue when add management port information, will verify link test further with optical module inserted later.
