Skip to content

Ladakh800bcls: fix exception in case AgentPacketSendTest.PortTxEnable…#914

Closed
gang-tao wants to merge 1 commit intofacebook:mainfrom
gang-tao:ladakh800bcls_agent_fix5
Closed

Ladakh800bcls: fix exception in case AgentPacketSendTest.PortTxEnable…#914
gang-tao wants to merge 1 commit intofacebook:mainfrom
gang-tao:ladakh800bcls_agent_fix5

Conversation

@gang-tao
Copy link
Contributor

@gang-tao gang-tao commented Feb 9, 2026

…Test
Pre-submission checklist

  • [✓ ] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • [✓ ] pre-commit run

Summary

when use switch 1 test case AgentPacketSendTest.PortTxEnableTest, it reports error:
F20260131 22:24:09.467856 69362 MultiSwitchHwSwitchHandler.cpp:416] Check failed: !transaction
*** Check failure stack trace: ***

Motivation

The test case failed because switch_id now need to be provided via command-line arguments according to the new requirements, but this wasn't updated. I am now applying the changes based on this commit.
6bba436#diff-a1e2a2b7d5175cc5451fbbde6dce83e58ed018ca8eb4f538c6e354bfa929a7cc

Test Plan

command

for switch in 0 1; do
  for filter in AgentPacketSendTest.PortTxEnableTest; do
    TS=$(date +%Y%m%d_%H%M%S)
    LD_LIBRARY_PATH=/opt/fboss/lib/ /root/gangtao/img/multi_switch_agent_hw_test \
    --gtest_filter=${filter} \
    --config /root/gangtao/cfg/link_test_config  \
    --platform_mapping_override_path /root/gangtao/cfg/ladakh800bc_platform_mapping_is_multi_npu.json-no-65 \
    --multi_npu_platform_mapping \
    --switch_id_for_testing ${switch} \
    --logging=DBG5 \
    2>&1 | tee /root/gangtao/log/case_rerun/multi_switch_agent-${TS}.log
  done
done

result

[       OK ] AgentPacketSendTest.PortTxEnableTest (529662 ms)
[       OK ] AgentPacketSendTest.PortTxEnableTest (746375 ms)

@meta-cla meta-cla bot added the CLA Signed label Feb 9, 2026
@meta-codesync
Copy link

meta-codesync bot commented Feb 10, 2026

@arunsarat has imported this pull request. If you are a Meta employee, you can view this in D92787192.

@meta-codesync
Copy link

meta-codesync bot commented Feb 18, 2026

@arunsarat merged this pull request in aea1665.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants