[Nexthop] Add fboss2-dev to Distro Image

[travisb-nexthop]

Pre-submission checklist

• I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
• pre-commit run

Summary

The fboss2-dev CLI command has recently been added to support configuring FBOSS. Add it to the Distro Image.

Test Plan

Validate that the command exists and executes in the image:

[root@dut ~]# /opt/fboss/bin/fboss2-dev -h
FBOSS CLI
Usage: /opt/fboss/bin/fboss2-dev [OPTIONS] SUBCOMMAND

Options:
  -h,--help                   Print this help message and exit
  -H,--host TEXT ...          Hostname(s) to query
  -l,--loglevel TEXT          Debug log level
  --file TEXT:FILE            filename, queries every host in the file
  --fmt TEXT:{tabular,json}   Output format (tabular, json)
  --agent-port INT:POSITIVE   Agent thrift port to connect to
  --qsfp-port INT:POSITIVE    QsfpService thrift port to connect to
  --color TEXT                color (no, yes => yes for tty and no for pipe)
  --filter TEXT               filter expression. expression must be of the form TERM1&&TERM2||TERM3||TERM4... where each TERMi is of the form <key op value> See specific commands for list of available filters. Please note the specific whitespace requirements for the command
  --aggregate TEXT            Aggregation operation. Must be of the form OPERATOR(column)
  --aggregate-hosts BOOLEAN   whether to perform aggregation across all hosts or not

Subcommands:
  bounce                      Disable/Enable object
  clear                       Clear object info
  config                      Configuration commands
  create                      Create object
  debug                       Debug object
  delete                      Delete object
  get                         Get object
  reload                      Reload object
  set                         Set object
  show                        Show object info
  start                       Start event
  stop                        Stop event
  stream                      Continuously stream

[root@dut ~]# 

[joseph5wu]

@travisb-nexthop : is it possible to make /opt/fboss/bin/ in $PATH so we can run fboss2-dev without specifying the absolute path?

[travisb-nexthop]

@travisb-nexthop : is it possible to make /opt/fboss/bin/ in $PATH so we can run fboss2-dev without specifying the absolute path?

Of course, but if we do that we probably want to move the daemons out into /opt/fboss/sbin or something so they can't be accidentally executed and don't clutter up tab completion. Does that sound acceptable?

[joseph5wu]

@travisb-nexthop : is it possible to make /opt/fboss/bin/ in $PATH so we can run fboss2-dev without specifying the absolute path?

Of course, but if we do that we probably want to move the daemons out into /opt/fboss/sbin or something so they can't be accidentally executed and don't clutter up tab completion. Does that sound acceptable?

I don't have strong preference here but we can set some standards for any non-service binary that where should we host these binaries.

Here's the example on our product NetOS

[netops@XXXXXX(container) (NETOS NSPAWN VARIANT) ~]
$ whereis fboss2
fboss2: /usr/local/bin/fboss2

$ ls -al /usr/local/bin/fboss2
-rwxr-xr-x 1 root root 437157192 Feb  4 17:40 /usr/local/bin/fboss2

$ echo $PATH
/usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin

$ ls -al /etc/packages/
total 0
drwxrwxr-x 1 root switching  286 Oct 30 16:23 .
drwxr-xr-x 1 root root      2726 Feb  9 07:04 ..
drwxr-xr-x 1 root root       206 Jan 26 14:01 neteng-fboss-bgpd
drwxr-xr-x 1 root root       206 Jan 26 14:01 neteng-fboss-fsdb
drwxr-xr-x 1 root root       206 Jan 26 14:01 neteng-fboss-qsfp_service
drwxr-xr-x 1 root root       206 Jan 26 13:55 neteng-fboss-qsfp_service-firmware
drwxr-xr-x 1 root root       206 Jan 26 14:01 neteng-fboss-wedge_agent
drwxr-xr-x 1 root root       206 Jan 26 14:01 openr
-rw-r--r-- 1 root root         0 Oct 15 15:36 .package_updater_lock

@kevin645 let me know what do you think

[joseph5wu]

Actually talked to Kevin, and it shouldn't be difficult to adjust the path or directory with a small diff in the future.
I agree that we don't have to put the whole /opt/fboss/bin/ in $PATH, maybe we can just create an fboss2-dev alias in /user/local/bin since we know it's an executable cli binary

[travisb-nexthop]

we can just create an fboss2-dev alias in /user/local/bin since we know it's an executable cli binary

Ok, how about I add a small wrapper script as /usr/local/bin/fboss2-dev (and for any other normal command) which invokes the correct binary? This wrapper will later work with component updating where the binary path is not always fixed under /opt/fboss. Similar to the unit drop-ins necessary for the services.