builtin file watcher: log when graph is dropped#1310
Open
lf- wants to merge 1 commit intofacebook:mainfrom
Open
builtin file watcher: log when graph is dropped#1310lf- wants to merge 1 commit intofacebook:mainfrom
lf- wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D103482839. (Because this pull request was imported automatically, there will not be any future comments.) |
Contributor
|
I'm not sure but you can probably just suspend buckd via /proc/sys/fs/inotify/max_queued_events is where new inotify instances get their queue size from during init. |
The file watcher can lose events due to event storms from the kernel or such; previously this was never actually reported. This reports it. Test plan: yolo. I don't really have a way to repro an event storm.
lf-
force-pushed
the
jade/push-vntvrmrtztsw
branch
from
094f1e7 to
de5fa9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file watcher can lose events due to event storms from the kernel or such; previously this was never actually reported. This reports it.
Test plan: yolo. I don't really have a way to repro an event storm.