fix: stop using broken buck-resources crate from crates.io#1307
Open
lf- wants to merge 2 commits intofacebook:mainfrom
Open
fix: stop using broken buck-resources crate from crates.io#1307lf- wants to merge 2 commits intofacebook:mainfrom
lf- wants to merge 2 commits intofacebook:mainfrom
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
Author
|
cc @scottcao, this issue was in my way while working on Buck OSS. |
Contributor
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D103452899. (Because this pull request was imported automatically, there will not be any future comments.) |
lf-
force-pushed
the
jade/push-tyryqpwmopxu
branch
from
8cf39e9 to
1e7ca52
Compare
Instead: use the one in-tree! The problem with the one on crates.io is that it got published with a BUCK file in the source tarball, so it breaks Buck when you `reindeer vendor` it as the sources are no longer visible. The crates.io publication should certainly be fixed, but there's no reason to use the crates.io version in-repo to begin with. Fixes: facebook#1226
lf-
force-pushed
the
jade/push-tyryqpwmopxu
branch
from
1e7ca52 to
98c4be1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead: use the one in-tree! The problem with the one on crates.io is that it got published with a BUCK file in the source tarball, so it breaks Buck when you
reindeer vendorit as the sources are no longer visible. The crates.io publication should certainly be fixed, but there's no reason to use the crates.io version in-repo to begin with.Fixes: #1226