Skip to content

fix: stabilize default resize snaps - #5276

Draft
nynexman4464 wants to merge 1 commit into
mainfrom
fix/stabilize-resizable-snaps
Draft

fix: stabilize default resize snaps#5276
nynexman4464 wants to merge 1 commit into
mainfrom
fix/stabilize-resizable-snaps

Conversation

@nynexman4464

Copy link
Copy Markdown
Contributor

Summary

  • replace the render-time snaps = [] default with one stable empty array per hook instance
  • keep expand, resize, and _snaps stable when callers omit snap points
  • add focused identity regression coverage

Fixes #5275.

Test plan

  • fail-first: the omitted-snaps identity test fails on main
  • pnpm vitest run packages/core/src/Resizable/useResizable.test.tsx packages/core/src/Resizable/ResizeHandle.test.tsx — 21 passed
  • pnpm -F @astryxdesign/core build
  • focused ESLint, formatting, sync, and changeset checks

@vercel

vercel Bot commented Aug 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
astryx Ready Ready Preview Aug 21, 2026 12:01am

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR Analysis Report

📚 Storybook Preview

View Storybook for this PR
GitHub Pages may take up to a minute to hydrate after deploy.

🧪 Sandbox Preview

View Sandbox for this PR
GitHub Pages may take up to a minute to hydrate after deploy.

Modified Components

Resizable (@astryxdesign/core) · View in Storybook
Metric Before After Delta
Bundle Size (ESM) N/A N/A N/A
Lines of Code N/A 733 -
Complexity N/A Very High (88) -

Bundle Size Summary

Package Size (ESM) Size (CJS) Gzipped
@astryxdesign/core N/A 4.8KB 1.2KB

Accessibility Audit

Status: No accessibility violations detected.


Generated by PR Enrichment workflow | Storybook | Sandbox | View full report

github-actions Bot added a commit that referenced this pull request Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] useResizable recreates callbacks when snaps are omitted

1 participant