docs(core): correct the v0.4.5 StatusDot changelog entry - #5265
Open
bhamodi wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
github-actions
Bot
added
community
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR No new or modified components detected. Bundle Size SummaryNo component packages changed. Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#4373 merged after a design-review reversal: the built-in per-variant glyphs (and the
statusdot:<variant>registry keys /astryx-statusdot-glyphtheme target) were removed, and only theiconprop + per-variant--color-on-*inks shipped. The changeset in that PR was committed with a stale body from the earlier revision -- it still described the glyph system -- and it was consumed into the released v0.4.5 CHANGELOG before anyone noticed.This corrects the
@astryxdesign/corev0.4.5 entry to describe what actually shipped: theiconescape hatch, the ink pairings (including the dark on-warning ink), and the design decision that the dot stays a plain colored signal with accessibility handled in context (per the #4737 usage guidance).Changes
packages/core/CHANGELOG.md-- replace the stale StatusDot v0.4.5 bullet (1 line)Test plan
prettier --check packages/core/CHANGELOG.md-- cleanNotes