Skip to content

Fix PowerSearch maxOperatorMenuItems - #5242

Open
nynexman4464 wants to merge 1 commit into
mainfrom
fix/powersearch-operator-menu-items
Open

Fix PowerSearch maxOperatorMenuItems#5242
nynexman4464 wants to merge 1 commit into
mainfrom
fix/powersearch-operator-menu-items

Conversation

@nynexman4464

Copy link
Copy Markdown
Contributor

Summary

  • wire the existing maxOperatorMenuItems prop through the PowerSearch edit popover
  • apply the limit to string, string-list, and entity-list value suggestions, including nested filters
  • document that this limit does not affect the main field search menu or enum value menus

Fixes #5241

Test plan

  • pnpm test
  • pnpm -F @astryxdesign/core typecheck
  • pnpm -F @astryxdesign/core build
  • pnpm lint:strict
  • reverted the implementation while keeping the new tests and confirmed the four limit assertions fail with 5–6 suggestions instead of 2; restored the implementation and confirmed they pass

@vercel

vercel Bot commented Aug 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
astryx Ready Ready Preview Aug 20, 2026 1:30am

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR Analysis Report

📚 Storybook Preview

View Storybook for this PR
GitHub Pages may take up to a minute to hydrate after deploy.

🧪 Sandbox Preview

View Sandbox for this PR
GitHub Pages may take up to a minute to hydrate after deploy.

Modified Components

PowerSearch (@astryxdesign/core) · View in Storybook
Metric Before After Delta
Bundle Size (ESM) N/A N/A N/A
Lines of Code N/A 3695 -
Complexity N/A Very High (336) -

Bundle Size Summary

Package Size (ESM) Size (CJS) Gzipped
@astryxdesign/core N/A 4.8KB 1.2KB

Accessibility Audit

Status: 1 accessibility violation(s) found — 1 serious.

PowerSearch - 1 issue(s)
  • 🟠 serious: Ensure the contrast between foreground and background colors meets WCAG 2 AA minimum contrast ratio thresholds
    • Rule: color-contrast · Affects 2/25 stories · Learn more
    • WCAG: 1.4.3 (Level AA)

Generated by PR Enrichment workflow | Storybook | Sandbox | View full report

@nynexman4464
nynexman4464 marked this pull request as ready for review August 20, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] PowerSearch maxOperatorMenuItems prop has no effect

1 participant