Skip to content

fix(core): bound PowerSearch field browsing at 1,000 - #5233

Open
nynexman4464 wants to merge 5 commits into
mainfrom
fix/powersearch-field-menu-cap
Open

fix(core): bound PowerSearch field browsing at 1,000#5233
nynexman4464 wants to merge 5 commits into
mainfrom
fix/powersearch-field-menu-cap

Conversation

@nynexman4464

@nynexman4464 nynexman4464 commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Summary

PowerSearch used the typeahead's generic 10-item default for both typed results and empty-query field browsing. This made configured fields after the first 10 inaccessible until users searched for them.

This change:

  • shows up to 1,000 configured fields while browsing with an empty query, matching the established safety ceiling in the predecessor component
  • keeps ranked results capped at 10 by default for non-empty queries
  • adds maxSearchResults to override the ranked-result cap without affecting browsing or field value editors

Fixes #5232.

Test plan

  • Added integration coverage for normal field browsing, the 1,000-row browsing ceiling, the default typed cap, and an explicit maxSearchResults override.
  • Added search-source coverage proving only non-empty queries are capped at the source level.
  • Verified the regression tests fail if browsing falls back to 10 items or becomes unbounded.
  • Ran the focused PowerSearch tests, core typecheck, and repository checks locally.
  • Full GitHub CI passes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 19, 2026
@vercel

vercel Bot commented Aug 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
astryx Ready Ready Preview Aug 20, 2026 11:33pm

Request Review

@github-actions

github-actions Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

PR Analysis Report

📚 Storybook Preview

View Storybook for this PR
GitHub Pages may take up to a minute to hydrate after deploy.

🧪 Sandbox Preview

View Sandbox for this PR
GitHub Pages may take up to a minute to hydrate after deploy.

Modified Components

PowerSearch (@astryxdesign/core) · View in Storybook
Metric Before After Delta
Bundle Size (ESM) N/A N/A N/A
Lines of Code N/A 3673 -
Complexity N/A Very High (336) -

Bundle Size Summary

Package Size (ESM) Size (CJS) Gzipped
@astryxdesign/core N/A 4.8KB 1.2KB

Accessibility Audit

Status: 1 accessibility violation(s) found — 1 serious.

PowerSearch - 1 issue(s)
  • 🟠 serious: Ensure the contrast between foreground and background colors meets WCAG 2 AA minimum contrast ratio thresholds
    • Rule: color-contrast · Affects 2/25 stories · Learn more
    • WCAG: 1.4.3 (Level AA)

Generated by PR Enrichment workflow | Storybook | Sandbox | View full report

github-actions Bot added a commit that referenced this pull request Aug 19, 2026
github-actions Bot added a commit that referenced this pull request Aug 19, 2026
@nynexman4464
nynexman4464 marked this pull request as ready for review August 20, 2026 20:22
@nynexman4464 nynexman4464 changed the title fix(core): show all PowerSearch fields while browsing fix(core): bound PowerSearch field browsing at 1,000 Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] PowerSearch truncates the field list while browsing

1 participant