-
Notifications
You must be signed in to change notification settings - Fork 357
Exclude 'step' from Sensitivity analysis by fixing step at full-progression 'step' #4777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sunnyshen321
wants to merge
1
commit into
facebook:main
Choose a base branch
from
sunnyshen321:export-D90819468
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sunnyshen321 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90819468. |
sunnyshen321
pushed a commit
to sunnyshen321/Ax
that referenced
this pull request
Jan 16, 2026
…ession 'step' (facebook#4777) Summary: This diff excludes the "step" feature (MAP_KEY) from sensitivity analysis plots by adding `exclude_map_key` and `target_step` parameters throughout the sensitivity computation. When `exclude_map_key=True` (the new default), the `ax_parameter_sens()` function fixes the step feature at the specified `target_step` value (or the maximum step if not provided) using a `FixedFeatureModel` wrapper, then computes Sobol indices over the remaining parameters. This ensures "step" never appears in the output, making sensitivity plots more interpretable for users who care about parameter effects at final performance rather than across all training steps. Differential Revision: D90819468
8766a45 to
d4aa24a
Compare
sunnyshen321
pushed a commit
to sunnyshen321/Ax
that referenced
this pull request
Jan 16, 2026
…ession 'step' (facebook#4777) Summary: This diff excludes the "step" feature (MAP_KEY) from sensitivity analysis plots by adding `exclude_map_key` and `target_step` parameters throughout the sensitivity computation. When `exclude_map_key=True` (the new default), the `ax_parameter_sens()` function fixes the step feature at the specified `target_step` value (or the maximum step if not provided) using a `FixedFeatureModel` wrapper, then computes Sobol indices over the remaining parameters. This ensures "step" never appears in the output, making sensitivity plots more interpretable for users who care about parameter effects at final performance rather than across all training steps. Differential Revision: D90819468
d4aa24a to
62bcf8f
Compare
…ession 'step' (facebook#4777) Summary: This diff excludes the "step" feature (MAP_KEY) from sensitivity analysis plots by adding `exclude_map_key` and `target_step` parameters throughout the sensitivity computation. When `exclude_map_key=True` (the new default), the `ax_parameter_sens()` function fixes the step feature at the specified `target_step` value (or the maximum step if not provided) using a `FixedFeatureModel` wrapper, then computes Sobol indices over the remaining parameters. This ensures "step" never appears in the output, making sensitivity plots more interpretable for users who care about parameter effects at final performance rather than across all training steps. Differential Revision: D90819468
62bcf8f to
29b8e17
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4777 +/- ##
==========================================
- Coverage 96.73% 96.61% -0.12%
==========================================
Files 585 586 +1
Lines 61196 61326 +130
==========================================
+ Hits 59195 59251 +56
- Misses 2001 2075 +74 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff excludes the "step" feature (MAP_KEY) from sensitivity analysis plots by adding
exclude_map_keyandtarget_stepparameters throughout the sensitivity computation. Whenexclude_map_key=True(the new default), theax_parameter_sens()function fixes the step feature at the specifiedtarget_stepvalue (or the maximum step if not provided) using aFixedFeatureModelwrapper, then computes Sobol indices over the remaining parameters.This ensures "step" never appears in the output, making sensitivity plots more interpretable for users who care about parameter effects at final performance rather than across all training steps.
Differential Revision: D90819468