Remove TestDataBase now that DataBase is gone #4772
+28
−92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: TData was necesssary whern we had multiple different Data classes, but recent developments have made this no longer needed Differential Revision: D90596942
Summary: Moved these tests into TestData, since Data is the only data-related class in Ax. Differential Revision: D90605845
meta-cla
bot
added
the
CLA Signed
|
@mpolson64 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90605845. |
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Jan 15, 2026
Summary: Moved these tests into TestData, since Data is the only data-related class in Ax. Differential Revision: D90605845
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4772 +/- ##
=======================================
Coverage 96.72% 96.72%
=======================================
Files 583 583
Lines 60860 60813 -47
=======================================
- Hits 58866 58823 -43
+ Misses 1994 1990 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Jan 15, 2026
Summary: Moved these tests into TestData, since Data is the only data-related class in Ax. Differential Revision: D90605845
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Moved these tests into TestData, since Data is the only data-related class in Ax.
Differential Revision: D90605845