Collapse the steering bar by default and expand it on bar click - #699
Conversation
The steering dock on run pages now starts collapsed, staying out of the way until the operator opens it. A run that is interrupted and waiting for steering still forces the dock open. While collapsed, the whole dock header is a click target that expands it. Clicks on buttons in the bar (Interrupt, the chevron) keep their own behavior, and the chevron remains the keyboard/assistive-tech toggle. The interview dock shares the shell, so it gets the same click-to-open behavior. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟡 Not ready to approve
The new RunDockShell click handler assumes event.target always supports .closest(), which can throw at runtime for some event targets unless guarded.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
This PR updates the run detail “steering” dock UX so the dock starts collapsed by default, while still forcing it open when a run is blocked waiting for operator steering. It also makes the collapsed dock header area clickable to expand (without interfering with button behavior), and applies the same shell behavior to the interview question dock for consistency.
Changes:
- Default the SteerBar dock to collapsed unless steering is actively required.
- Add “click header to expand” behavior to
RunDockShellonly when collapsed, excluding clicks on header buttons. - Update/add React test-renderer coverage for the new default collapsed state and header click-target behavior.
File summaries
| File | Description |
|---|---|
| apps/fabro-web/app/components/steer-bar.tsx | Changes the steering dock’s default collapsed preference and retains “force open while waiting for steer” behavior. |
| apps/fabro-web/app/components/steer-bar.test.tsx | Updates the focus/expand test to reflect the new default-collapsed behavior. |
| apps/fabro-web/app/components/run-dock.tsx | Makes the collapsed header bar clickable to expand, while preserving button behavior and the chevron’s accessibility role. |
| apps/fabro-web/app/components/run-dock.test.tsx | Adds tests for RunDockShell header click-to-expand behavior and exclusion for button clicks / expanded state. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
There was a problem hiding this comment.
🟢 Ready to approve
The changes are small, consistent with the PR description, and the updated/new tests directly cover the adjusted collapsed/expand interaction behavior.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0 new
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
Summary
RunDockShell, so it gets the same click-to-open behavior for consistency.Test plan
bun test run-dock steer-bar— updated the steer-bar focus test for the new default; addedRunDockShelltests for the collapsed click target, the button-click exclusion, and the expanded header not being clickablebun run typecheckbun testsuite: same 13 pre-existing failures as clean main (build-version, import-chunk, run-files); no new failures🤖 Generated with Claude Code