fix(daytona): accept newer permission scopes - #698
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Fabro’s Daytona integration to tolerate new permission scopes returned by the Daytona API by pinning to an updated daytona-sdk-rust revision, and expands the existing credential-probe test to include currently observed “new” scopes while still enforcing Fabro’s required snapshot/sandbox scopes.
Changes:
- Bump
daytona-sdk/daytona-api-clientgit revisions to73c9c458dd1a1d096afd3521175637af82afd8d8. - Extend the Daytona API key validation test to include additional non-required scopes (
manage:secrets,read:limits,manage:sso) in the mocked API response. - Update
Cargo.lockto reflect the new git sources for the Daytona crates.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/components/fabro-sandbox/src/daytona/mod.rs | Updates the API-key scope validation test to ensure extra/new scopes in the response don’t break Fabro’s required-scope checks. |
| Cargo.toml | Pins Daytona SDK/client dependencies to the updated upstream commit. |
| Cargo.lock | Locks the updated Daytona dependency sources to the new git revision. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fabro still checks for all four required snapshot and sandbox scopes. Request-side permission parsing remains strict.
Dependency
Tests
Security review
No findings. Unknown response scopes cannot satisfy any required Fabro permission check.